Skip to content

POWER: Fixing syntax error in makefile#3367

Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom
RajalakshmiSR:makesyntax
Sep 8, 2021
Merged

POWER: Fixing syntax error in makefile#3367
martin-frbg merged 1 commit intoOpenMathLib:developfrom
RajalakshmiSR:makesyntax

Conversation

@RajalakshmiSR
Copy link
Copy Markdown

Fixing syntax issue in Makefile.power added by recent commit
af19cda

Fixing syntax issue in Makefile.power added by recent commit
af19cda
@martin-frbg
Copy link
Copy Markdown
Collaborator

Aww, sorry for that.

@RajalakshmiSR
Copy link
Copy Markdown
Author

Do you know how we can avoid these issues with our Travis CI as we have POWER9 added in Travis. Ref : #2754

@martin-frbg
Copy link
Copy Markdown
Collaborator

I do not think Travis (or actually OSUOSL providing the POWER9 hardware to them) is offering POWER10 yet. Perhaps I can set up qemu (POWER10 support appears to be very limited but may be enough to get a build started), but primarily I need to be more
careful with edits (or stop using github's simple web editor for good)

@RajalakshmiSR
Copy link
Copy Markdown
Author

Yes we don’t have POWER10 yet in OSUOSL, but the question is about general POWER testing and not related to this issue/PR.
Do we have an active POWER build job?

@martin-frbg
Copy link
Copy Markdown
Collaborator

The one in Travis is active again since a few days (needed xianyi to initiate the migration to travis.com and apply for free credits). But it cannot catch bugs that I introduce in P10-specific sections of the Makefile.

@RajalakshmiSR
Copy link
Copy Markdown
Author

Thanks @martin-frbg

@martin-frbg martin-frbg merged commit 3e8c448 into OpenMathLib:develop Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants